Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add default alwaysPrompt value in OAuthInput step #2266

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

alanlong9278
Copy link
Contributor

@alanlong9278 alanlong9278 commented Mar 13, 2020

Description

add default alwaysPrompt value in OAuthInput step.

There is a bug in SDK, that requires alwaysPrompt property must have value, otherwise it will throw an exception called : Object reference to null.

This PR is to hotfix that issue in Composer side to work around that bug.

Task Item

fixes #2266

Screenshots

@github-actions
Copy link

Coverage Status

Coverage remained the same at 40.796% when pulling 6be70ae on julong/alwaysPromptInOAuth into bbaad90 on master.

@luhan2017
Copy link
Contributor

This is a hotfix for the OAuth issue.

@luhan2017 luhan2017 merged commit 951d78f into master Mar 13, 2020
@luhan2017 luhan2017 deleted the julong/alwaysPromptInOAuth branch March 13, 2020 10:00
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants